RFR: 8303972: (zipfs) Make test/jdk/jdk/nio/zipfs/TestLocOffsetFromZip64EF.java independent of the zip command line

Eirik Bjørsnøs eirbjo at openjdk.org
Thu Feb 15 13:52:05 UTC 2024


On Fri, 10 Mar 2023 20:34:56 GMT, Eirik Bjørsnøs <eirbjo at openjdk.org> wrote:

>>> Not sure I understand. I could use FileChannel.open with SPARSE (which btw is ignored by the implementation:)
>> 
>> That is true on platforms where files can be sparse by default. On Windows you'll see this translates to create the file as sparse, it needs to be opt-in when creating the file.
>
> I opted to create a small-sized Zip64 file instead (see below). This file does not need to be sparse.

> That is true on platforms where files can be sparse by default. On Windows you'll see this translates to create the file as sparse, it needs to be opt-in when creating the file.

Thanks for this info, Alan!

While this PR no longer makes use of sparse files, I have applied your comments about FileChannel.open for NTFS in another PR (which does make use of sparse files):

https://github.com/openjdk/jdk/pull/12948

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/12979#discussion_r1132891686


More information about the nio-dev mailing list