RFR: 8310994: Add JFR event for selection operations [v2]
Daniel Fuchs
dfuchs at openjdk.org
Mon Feb 26 14:27:03 UTC 2024
On Wed, 13 Dec 2023 18:49:08 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:
>> Tim Prinzing has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 12 additional commits since the last revision:
>>
>> - Change event generation:
>>
>> - selectNow is filtered out
>> - select that times out is always sent
>> - select without timeout uses duration test
>> - rename event to SelectorSelect, field to selectionKeyCount.
>> - Merge branch 'master' into JDK-8310994
>> - remove trailing whitespace
>> - event logic outside of the lock, selector in try block
>> - remove unused import
>> - fix TestConfigure failure
>> - add event defaults
>> - Merge branch 'master' into JDK-8310994
>> - minor test cleanup
>> - ... and 2 more: https://git.openjdk.org/jdk/compare/9896b3fb...2f7dafd8
>
> src/jdk.jfr/share/classes/jdk/jfr/events/SelectorSelectEvent.java line 44:
>
>> 42: @Label("SelectionKey Count")
>> 43: @Description("Number of channels ready for I/O or added to ready set")
>> 44: public int selectionKeyCount;
>
> same here
Thanks for adding the timeout.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16710#discussion_r1502686107
More information about the nio-dev
mailing list