RFR: 8324972: (bf) Make DirectByteBuffer.Deallocator idempotent [v3]

Aleksey Shipilev shade at openjdk.org
Wed Jan 31 16:47:02 UTC 2024


On Wed, 31 Jan 2024 16:44:17 GMT, Per Minborg <pminborg at openjdk.org> wrote:

>> This PR proposes to make deallocators and unmappers for memory regions idempotent. This is to prevent (likely very rare) duplicate invocations. 
>> 
>> There are no unit tests but it should be noted that the idempotent behavior (now correct) is similar to the  intended behavior before cf74b8c2a32f33019a13ce80b6667da502cc6722 but where idempotency was not guaranteed in a multi-threaded environment.
>> 
>> Passes tier1, 2, and 3 tests.
>
> Per Minborg has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Swith to using Unsafe

src/java.base/share/classes/sun/nio/ch/FileChannelImpl.java line 50:

> 48: import java.nio.channels.WritableByteChannel;
> 49: import java.util.Objects;
> 50: import java.util.concurrent.atomic.AtomicIntegerFieldUpdater;

Unused import?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17647#discussion_r1473139220


More information about the nio-dev mailing list