RFR: 8336675: Remove UnixFileSystemProvider.checkPath in favor of UnixPath.toUnixPath

Jaikiran Pai jpai at openjdk.org
Thu Jul 18 06:40:30 UTC 2024


On Fri, 12 Jul 2024 11:54:15 GMT, Andrey Turbanov <aturbanov at openjdk.org> wrote:

> Implementation of both methods is the same.
> https://github.com/openjdk/jdk/blob/9b6f6c5c9dd6d0fbb056e8d84c3a0888a3320edf/src/java.base/unix/classes/sun/nio/fs/UnixFileSystemProvider.java#L129-L135
> 
> https://github.com/openjdk/jdk/blob/9b6f6c5c9dd6d0fbb056e8d84c3a0888a3320edf/src/java.base/unix/classes/sun/nio/fs/UnixPath.java#L172-L179
> 
> `UnixPath.toUnixPath` is already used by UnixFileSystemProvider in multiple places. Two more usages shouldn't cause problems.

Looks OK to me, but please wait for another review from someone in this area.
Have relevant tier tests been run after this change?

-------------

Marked as reviewed by jpai (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/20155#pullrequestreview-2184848066


More information about the nio-dev mailing list