RFR: 8336529: (fs) UnixFileAttributeViews setTimes() failing on armhf, Ubuntu noble [v3]

[Vladimir Petko]

On Fri, 19 Jul 2024 08:34:01 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Vladimir Petko has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review comments: use a separate ifdef statement.
>
> src/java.base/unix/native/libnio/fs/UnixNativeDispatcher.c line 265:
> 
>> 263:     return ret;
>> 264: }
>> 265: #endif
> 
> I assume you will move to after statx_wrapper and just replace the body with a simple if-then-else.

if/else will not work in a general case, even in Debian where x32 arch has 64 bit time_t but no 64 bit functions, so I have to lookup 64 bit one and, if it fails, fall back to a general symbol. I can make this change, but it might cause an issue in some edge cases.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20208#discussion_r1684080406