RFR: 8336844: ZipConstants64 defines duplicate constants EXTID_ZIP64 and ZIP64_EXTID [v2]

[Jaikiran Pai]

On Sat, 20 Jul 2024 02:18:11 GMT, Liam Miller-Cushon <cushon at openjdk.org> wrote:

>> This change deduplicates constants in ZipConstants64 for the Zip64 Extended Information Extra Field Header ID (see APPNOTE.TXT 4.5.3).
>> 
>> I think there are arguments for consolidating on either `EXTID_ZIP64` or `ZIP64_EXTID`. The PR currently consolidates on `EXTID_ZIP64`, `ZIP64_EXTID` is also an option if there's a preference for that.
>> 
>> I noticed this while working on a zip64 bug in [JDK-8328995](https://bugs.openjdk.org/browse/JDK-8328995), I was reviewing places that handled zip64 extra fields and initially missed some because I was only looking at one of the constants.
>
> Liam Miller-Cushon has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - Merge remote-tracking branch 'origin/master' into zip64_extid
>  - Update copyright year
>  - 8336844: ZipConstants64 defines duplicate constants EXTID_ZIP64 and EXTID_ZIP64.

The changes look good to me. Although a trivial change, it would be good to wait for Lance to review this before integrating.

-------------

Marked as reviewed by jpai (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/20264#pullrequestreview-2189766637