RFR: 8334405: java/nio/channels/Selector/SelectWithConsumer.java#id0 failed in testWakeupDuringSelect

Alan Bateman alanb at openjdk.org
Wed Jul 31 08:17:31 UTC 2024


On Tue, 30 Jul 2024 23:54:09 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

> Replace differences of milliseconds vs. epoch to differences of nanoseconds per the JVM's high-resolution time source.

Changing the test to use System.nanoTimes is good. I think I'd prefer if the assert message included both the expected and actual to make failure analysis a bit easier, only because these tests run with several VM modes that significantly slow execution, in addition to the clock changing. Also it usually a bit easier to see durations presented in millis, look at the tests that use expectDuration for examples.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20398#issuecomment-2259929595


More information about the nio-dev mailing list