RFR: 8334297: (so) java/nio/channels/SocketChannel/OpenLeak.java should not depend on SecurityManager [v5]

Daniel Fuchs dfuchs at openjdk.org
Tue Jun 18 14:02:11 UTC 2024


On Tue, 18 Jun 2024 11:40:10 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> The reason I do that is to record the testcase for ConnectException as aborted (Assumptions.abort will be called, and it will appear in the summary). But maybe that's not useful? There are only two test cases anyway: one for unresolved address and one for connection refused.
>
> Using assume to test the runtime or some configuration before running a test is fine. It's just a bit unusual here that the method source produces a test case that can't be used. I don't object to the current version, just a bit unusual to see this.

OK - I have changed it to not produce the test case.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19723#discussion_r1644521117


More information about the nio-dev mailing list