RFR: 8332535: Mark java/nio/channels/DatagramChannel/Loopback.java as intermittent [v2]

Daniel Fuchs dfuchs at openjdk.org
Tue Jun 25 14:51:13 UTC 2024


On Tue, 28 May 2024 03:11:19 GMT, SendaoYan <syan at openjdk.org> wrote:

>> Hi all,
>>   The test `test/jdk/java/nio/channels/DatagramChannel/Loopback.java` intermittent fail, the failure probability is about 2/1000. This PR mark this test intermittent, and print more messages to investigate the intermittent failure. Only change the testcase, no risk.
>
> SendaoYan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
> 
>  - Merge branch 'openjdk:master' into jbs8332535
>  - 8332535: Mark java/nio/channels/DatagramChannel/Loopback.java as intermittent
>    
>    Signed-off-by: sendaoYan <yansendao.ysd at alibaba-inc.com>

test/jdk/java/nio/channels/DatagramChannel/Loopback.java line 164:

> 162:                             System.out.format("received %s from %s%n", dst, sender);
> 163:                             senderPort = ((InetSocketAddress) sender).getPort();
> 164:                             assertTrue(senderPort != localPort, "Unexpected message: localPort=" + localPort);

I wonder if we should add some entropy to the message content and discard any message that we receive whose payload doesn't match what we expect.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19314#discussion_r1652979834


More information about the nio-dev mailing list