RFR: 8269657: Test Loopback.java failed: Unexpected message [v7]

[Daniel Fuchs]

On Thu, 27 Jun 2024 07:28:39 GMT, SendaoYan <syan at openjdk.org> wrote:

>> Hi all,
>>   The test `test/jdk/java/nio/channels/DatagramChannel/Loopback.java` intermittent fail, the failure probability is about 2/1000. 
>> This PR mark add some entropy(System.nanoTime) to the message content, and if the payloads doesn't match then ignore it, because payloads probably receiving some stray packet sent by another process. Only if the port unmatch and the content match we consider it a failure.
>> The change has been verified locally, I have runed the test after the this patch 20k times and all passed. Only change the testcase, no risk.
>
> SendaoYan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   delete @key intermittent

test/jdk/java/nio/channels/DatagramChannel/Loopback.java line 25:

> 23: 
> 24: /* @test
> 25:  * @bug 8236184 8332535

You can remove 8332535 here. We usually only put bug ids here if there are source code changes that the test is testing. If the bug being fixed is in the test itself, we don't list the bug id here.
Suggestion:

 * @bug 8236184


My tests were positive. I will approve after you make this change.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19314#discussion_r1658361614