RFR: 8327046: (fs) Files.walk should be clear that depth-first traversal is pre-order [v3]

[Guoxiong Li]

On Thu, 29 Feb 2024 15:03:18 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

>> Please review this clarification to the specification of the two overloads of `java.nio.file.Files.walk`. No tests are added, as I believe the existing `StreamTest.testWalk*` methods already test the order sufficiently. I also took this opportunity to fix a few minor typos.
>
> Pavel Rappo has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Respond to feedback

A trivial issue about the name.

test/jdk/java/nio/file/Files/StreamTest.java line 78:

> 76:     static Path[] level1;
> 77:     static Path[] all;
> 78:     static Path[] all_followLinks;

The name `all_followLinks`, which contains the underline and the lower camel case, is strange. What about `allFollowLinks`?

-------------

Changes requested by gli (Committer).

PR Review: https://git.openjdk.org/jdk/pull/18063#pullrequestreview-1910520607
PR Review Comment: https://git.openjdk.org/jdk/pull/18063#discussion_r1508614405