RFR: JDK-8327444: simplify RESTARTABLE macro usage in JDK codebase [v2]

Alan Bateman alanb at openjdk.org
Wed Mar 6 15:51:46 UTC 2024


On Wed, 6 Mar 2024 15:45:16 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

>> We define the RESTARTABLE macro again and again at a lot of places in the JDK native codebase. This could be centralized to avoid repeating it again and again !
>
> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
> 
>   introduce unix jni_util_md.h

src/java.base/aix/native/libnio/ch/Pollset.c line 29:

> 27: #include "jni.h"
> 28: #include "jni_util.h"
> 29: #include "jni_util_md.h"

When I suggested jni_util_md.h then I meant create one for Unix and another for Windows, then have jni_util.h include it. This will avoid needing to add an include to all these files.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18132#discussion_r1514724921


More information about the nio-dev mailing list