RFR: 8298318: (fs) APIs for handling filename extensions [v4]

Louis Bergelson duke at openjdk.org
Thu Mar 7 20:35:55 UTC 2024


On Thu, 7 Mar 2024 16:59:54 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8298318: Remove vestigial trim() call and commented out methods
>
> test/jdk/java/nio/file/Path/Extensions.java line 81:
> 
>> 79:             {"compress.gzip",  "gzip"},
>> 80:             {"waitwhat.&$!#%", "&$!#%"},
>> 81:             {"6.283185307",    "283185307"}
> 
> The behavior of these test cases is good, these are the expected results of getExtension().

These should probably include some compound extensions as well?   ex: "archive.tar.gz"

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16226#discussion_r1516786826


More information about the nio-dev mailing list