RFR: 8327096: (fc) java/nio/channels/FileChannel/Size.java fails on partition incapable of creating large files [v2]

Daniel Jeliński djelinski at openjdk.org
Tue Mar 12 07:14:13 UTC 2024


On Mon, 11 Mar 2024 21:48:15 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

>> If an `IOException` with message "File too large" is thrown while testing with a large file, then ignore the exception if the type of the `FileStore` where the file would be located is "msdos".
>
> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8327096: Throw SkippedException instead of silently ignoring failure on FAT32

Looks reasonable. Thanks.

-------------

Marked as reviewed by djelinski (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18073#pullrequestreview-1930258183


More information about the nio-dev mailing list