RFR: 8313674: java/nio/channels/FileChannel/BlockDeviceSize.java should test for more block devices [v4]
Inigo Mediavilla Saiz
duke at openjdk.org
Mon May 13 07:51:21 UTC 2024
On Tue, 7 May 2024 16:53:23 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:
>> Inigo Mediavilla Saiz has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Aligning test summary with the test implementation.
>
> test/jdk/java/nio/channels/FileChannel/BlockDeviceSize.java line 47:
>
>> 45: public static void main(String[] args) throws Throwable {
>> 46: for (String blkFname: BLK_FNAMES) {
>> 47: Path blkPath = Paths.get(blkFname);
>
> I suggest using `Path.of` here as recommended by the API Note in the specification of [java.nio.file.Paths](https://docs.oracle.com/en/java/javase/22/docs/api/java.base/java/nio/file/Paths.html).
Thanks ! I've done that in https://github.com/openjdk/jdk/pull/19021/commits/39e348b334c17365c95b14419f56aa605defd20d
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19021#discussion_r1598023216
More information about the nio-dev
mailing list