RFR: 8313674: (fc) java/nio/channels/FileChannel/BlockDeviceSize.java should test for more block devices [v6]
Alan Bateman
alanb at openjdk.org
Tue May 14 17:32:11 UTC 2024
On Mon, 13 May 2024 08:36:40 GMT, Inigo Mediavilla Saiz <duke at openjdk.org> wrote:
>> 8313674: (fc) java/nio/channels/FileChannel/BlockDeviceSize.java should test for more block devices
>
> Inigo Mediavilla Saiz has updated the pull request incrementally with two additional commits since the last revision:
>
> - Included <= as a failure condition for the test
> - Updated the latest year for the copyright
test/jdk/java/nio/channels/FileChannel/BlockDeviceSize.java line 64:
> 62: " Skipping test");
> 63: } catch (AccessDeniedException ade) {
> 64: throw new RuntimeException("Access to " + blkFname + " is denied."
Looking at it again, this should be SkipException rather RuntimeException, otherwise the test will fail when denied.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19021#discussion_r1600408693
More information about the nio-dev
mailing list