RFR: 8327650: Test java/nio/channels/DatagramChannel/StressNativeSignal.java timed out [v4]

[Mark Sheppard]

On Tue, 21 May 2024 16:23:45 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Mark Sheppard has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   JDK-8327650: Test java/nio/channels/DatagramChannel/StressNativeSignal.java timed out — updated catch block to be consistent with idiom used in test
>
> test/jdk/java/nio/channels/DatagramChannel/StressNativeSignal.java line 82:
> 
>> 80:         private volatile boolean shouldTerminate;
>> 81:         private ServerSocket socket;
>> 82:         private volatile CountDownLatch threadStarted = new CountDownLatch(1);
> 
> This should be final rather than volatile.

done

> test/jdk/java/nio/channels/DatagramChannel/StressNativeSignal.java line 133:
> 
>> 131:         private DatagramChannel channel;
>> 132:         private volatile boolean shouldTerminate;
>> 133:         private volatile CountDownLatch threadStarted = new CountDownLatch(1);
> 
> This should be final, not volatile.

done

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19312#discussion_r1617239003
PR Review Comment: https://git.openjdk.org/jdk/pull/19312#discussion_r1617240109