RFR: 8343234: (bf) Move java/nio/Buffer/LimitDirectMemory.java from ProblemList.txt to ProblemList-Virtual.txt [v2]

[Jaikiran Pai]

On Fri, 1 Nov 2024 16:31:46 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

>> Move LimitDirectMemory to the problem list which best matches the observed failure mode.
>
> Brian Burkhalter has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - 8343234: Add aarch64 to allowed arch of LimitDirectMemory
>  - 8343234: Add java/nio/Buffer/LimitDirectMemory.java to ProblemList-Virtual.txt

The change looks reasonable to me. I've added an inline comment about the `@requires` in the test. I don't have a strong preference about it and it's OK if you want to continue using it in the proposed form.

test/jdk/java/nio/Buffer/LimitDirectMemory.java line 28:

> 26:  * @bug 4627316 6743526
> 27:  * @summary Test option to limit direct memory allocation
> 28:  * @requires (os.arch == "x86_64") | (os.arch == "amd64") | (os.arch == "aarch64")

Hello Brian, this seems to cover all the platforms that mainline currently supports. So I'm not sure if the `@requires` is anymore needed. I couldn't find the historical context on why that `@requires` was added in the first place.

-------------

Marked as reviewed by jpai (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/21773#pullrequestreview-2411228561
PR Review Comment: https://git.openjdk.org/jdk/pull/21773#discussion_r1826541339