RFR: 8343234: (bf) Move java/nio/Buffer/LimitDirectMemory.java from ProblemList.txt to ProblemList-Virtual.txt [v2]
Brian Burkhalter
bpb at openjdk.org
Mon Nov 4 18:21:37 UTC 2024
On Sat, 2 Nov 2024 10:26:50 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:
>> test/jdk/java/nio/Buffer/LimitDirectMemory.java line 28:
>>
>>> 26: * @bug 4627316 6743526
>>> 27: * @summary Test option to limit direct memory allocation
>>> 28: * @requires (os.arch == "x86_64") | (os.arch == "amd64") | (os.arch == "aarch64")
>>
>> Hello Brian, this seems to cover all the platforms that mainline currently supports. So I'm not sure if the `@requires` is anymore needed. I couldn't find the historical context on why that `@requires` was added in the first place.
>
> Never mind, I just realized that I hadn't taken into account other architectures like `riscv64`, `ppc64le` and similar. Although this test might still pass there, I think it's reasonable to continue to use the `@requires` like you have done here.
Thanks, @jaikiran, for noticing this. I don't know the whole story about `@requires` here and this combination is tested.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21773#discussion_r1828184260
More information about the nio-dev
mailing list