RFR: 8344112: Remove code to support security manager execution mode from DatagramChannel implementation
Daniel Fuchs
dfuchs at openjdk.org
Wed Nov 13 15:20:51 UTC 2024
On Wed, 13 Nov 2024 15:12:29 GMT, Alan Bateman <alanb at openjdk.org> wrote:
>> src/java.base/share/classes/sun/nio/ch/DatagramChannelImpl.java line 633:
>>
>>> 631: try {
>>> 632: SocketAddress sender = sourceSocketAddress();
>>> 633: synchronized (p) {
>>
>> I wonder if we should rip off the use of `synchronized (p)` in this method and call
>>
>> synchronized (p) {
>> blockingReceive(p, ...);
>> }
>>
>>
>> In the adaptor instead, like it used to be before virtual threads came into the picture?
>
> Not this PR but there is a follow-up coming that will drop the dependency on DatagramPacket from DatagramChannelImpl so that it does back to the adaptor.
OK - if you have follow-ups in the pipe to fix this then good to go!
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22072#discussion_r1840556553
More information about the nio-dev
mailing list