RFR: 8343785: (fs) Remove syscalls that set file times with microsecond precision [v2]

Brian Burkhalter bpb at openjdk.org
Wed Nov 13 16:13:28 UTC 2024


On Wed, 13 Nov 2024 09:57:47 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8343785: Use file descriptor in preference to path; add AIX to test @requires
>
> src/java.base/unix/classes/sun/nio/fs/UnixFileAttributeViews.java line 80:
> 
>> 78:             // if path is a symlink, then the open should fail with ELOOP and
>> 79:             // the path will be used instead of the file descriptor.
>> 80:             boolean haveFd = false;
> 
> In passing, we don't need haveFd, instead we can use fd >= 0 as is done in other places.

Yes, I had thought of ding that but left `haveFd` as it had been there before. Will change.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21989#discussion_r1840717319


More information about the nio-dev mailing list