RFR: 8344078: Remove security manager dependency in java.nio [v2]

Naoto Sato naoto at openjdk.org
Fri Nov 15 17:33:52 UTC 2024


On Fri, 15 Nov 2024 16:38:09 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

>> Expunge the use of the `SecurityManager`, `AccessController`, and the like from the `java.nio` and `sun.nio` package hierarchies.
>
> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8344078: Update overlooked CopyMoveHelper and CompletedFuture

Looked at charset related changes (Charset.java/CharsetMapping.java). Looks good overall with one minor comment.

src/java.base/share/classes/java/nio/charset/Charset.java line 371:

> 369:                                 // Ignore security exceptions
> 370:                                 continue;
> 371:                             }

Removing this part makes the comment (L347-349) moot.

-------------

PR Review: https://git.openjdk.org/jdk/pull/22132#pullrequestreview-2439237162
PR Review Comment: https://git.openjdk.org/jdk/pull/22132#discussion_r1844218817


More information about the nio-dev mailing list