RFR: 8344078: Remove security manager dependency in java.nio [v2]
Brian Burkhalter
bpb at openjdk.org
Fri Nov 15 18:04:02 UTC 2024
On Fri, 15 Nov 2024 17:03:13 GMT, Roger Riggs <rriggs at openjdk.org> wrote:
>> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
>>
>> 8344078: Update overlooked CopyMoveHelper and CompletedFuture
>
> src/java.base/share/classes/java/nio/file/Files.java line 1528:
>
>> 1526: list.add(detector);
>> 1527: }
>> 1528: return list;
>
> Possible refactor to use stream API: (may be a bit too aggressive)
> Suggestion:
>
> return ServiceLoader
> .load(FileTypeDetector.class, ClassLoader.getSystemClassLoader())
> .stream()
> .map(p -> (FileTypeDetector)p).toList();
Thanks for the suggestion. Perhaps in a later commit: I would prefer to keep the initial changes closed to the original.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22132#discussion_r1844265182
More information about the nio-dev
mailing list