RFR: 8344078: Remove security manager dependency in java.nio [v3]
Alan Bateman
alanb at openjdk.org
Sat Nov 16 09:14:56 UTC 2024
On Sat, 16 Nov 2024 00:33:13 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:
>> Expunge the use of the `SecurityManager`, `AccessController`, and the like from the `java.nio` and `sun.nio` package hierarchies.
>
> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
>
> 8344078: Address reviewer comments
src/java.base/share/classes/sun/nio/ch/SocketChannelImpl.java line 1604:
> 1602: if (addr != null) {
> 1603: sb.append(" local=");
> 1604: sb.append(addr.toString());
I assume you don't need the toString() here, sb.append(addr) will do.
src/java.base/share/classes/sun/nio/ch/ThreadPool.java line 76:
> 74: t.setDaemon(true);
> 75: return t;
> 76: };
This is another case where we should move to InnocuousThread, not this PR of course.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22132#discussion_r1844942048
PR Review Comment: https://git.openjdk.org/jdk/pull/22132#discussion_r1844942162
More information about the nio-dev
mailing list