RFR: 8344078: Remove security manager dependency in java.nio [v3]

Alan Bateman alanb at openjdk.org
Sat Nov 16 09:40:47 UTC 2024


On Sat, 16 Nov 2024 06:13:13 GMT, Glavo <duke at openjdk.org> wrote:

>> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8344078: Address reviewer comments
>
> src/java.base/share/classes/sun/nio/ch/AsynchronousChannelGroupImpl.java line 48:
> 
>> 46:     // thread pool. Internal threads do not dispatch to completion handlers.
>> 47:     private static final int internalThreadCount =
>> 48:         Integer.valueOf(System.getProperty("sun.nio.ch.internalThreadPoolSize", "1"));
> 
> Suggestion:
> 
>         Integer.getInteger("sun.nio.ch.internalThreadPoolSize", 1);

Yes, the it should use Integer.getInteger here, same thing in Invoker.java.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22132#discussion_r1844945498


More information about the nio-dev mailing list