RFR: 8343823: (fs) Files.createLink: inconsistent behavior when creating link to symbolic link [v2]

Alan Bateman alanb at openjdk.org
Wed Nov 20 17:37:20 UTC 2024


On Wed, 20 Nov 2024 16:12:06 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

>> Add an API note to `java.nio.file.Files.createLink` to make explicit that the behavior when the target is a symbolic link is unspecified.
>
> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8343823: Move API note verbiage into the method description

src/java.base/share/classes/java/nio/file/Files.java line 987:

> 985:      * known as creating a "hard link". Whether the file attributes are
> 986:      * maintained for the file or for each directory entry is file system
> 987:      * specific and therefore not specified. If the {@code existing} parameter

Thanks for moving the method description. Can you try putting the new sentence before the "Typically, a file system" sentence as I think will flow a bit better.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22257#discussion_r1850733371


More information about the nio-dev mailing list