RFR: 8341282: (fs) Move creation time fallback logic to Java layer (Linux) [v2]

Severin Gehwolf sgehwolf at openjdk.org
Tue Oct 1 18:21:36 UTC 2024


On Tue, 1 Oct 2024 17:37:49 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

>> Move the decision as to whether `BasicFileAttributes.creationTime()` falls back to the modified time from the native layer to the Java layer.
>
> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8341282: birthtime_invalid -> birthtime_available

LGTM

src/java.base/unix/native/libnio/fs/UnixNativeDispatcher.c line 633:

> 631:     // filled in if and only if the STATX_BTIME bit is set in the mask.
> 632:     // Although the statx system call might be supported by the operating
> 633:     // system, the birth time is not necessarily supported by the file system.

Nice comment!

-------------

Marked as reviewed by sgehwolf (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/21274#pullrequestreview-2341091855
PR Review Comment: https://git.openjdk.org/jdk/pull/21274#discussion_r1783306033


More information about the nio-dev mailing list