RFR: 8341282: (fs) Move creation time fallback logic to Java layer (Linux) [v4]

Alan Bateman alanb at openjdk.org
Wed Oct 2 17:17:40 UTC 2024


On Wed, 2 Oct 2024 16:54:24 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

>> Move the decision as to whether `BasicFileAttributes.creationTime()` falls back to the modified time from the native layer to the Java layer.
>
> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8341282: Make birthtime_available default false and set to true where needed

src/java.base/unix/native/libnio/fs/UnixNativeDispatcher.c line 629:

> 627:     (*env)->SetLongField(env, attrs, attrs_st_birthtime_sec, (jlong)buf->stx_btime.tv_sec);
> 628:     (*env)->SetLongField(env, attrs, attrs_st_birthtime_nsec, (jlong)buf->stx_btime.tv_nsec);
> 629: 

I think I need a reminder as to why we put values into these two fields when not available.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21274#discussion_r1784926276


More information about the nio-dev mailing list