RFR: 8338884: java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#tmp fails on alinux3 [v18]

SendaoYan syan at openjdk.org
Wed Oct 9 01:16:59 UTC 2024


> Hi all,
> On alinux3(alibaba cloud linux version 3) system, the `/tmp` disk partition is mounted as tmpfs filesystem type, this filesystem type doesn't support create time(birth time).
> 
> Before this PR, this test [check](https://github.com/openjdk/jdk/blob/master/test/jdk/java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#L110) if there is `statx` system call present or not to determise the test environment support birth time or not. I think it's not enough when the tested filesystem type is `tmpfs`. When the tested filesystem type is `tmpfs`, then the tested file doesn't support birth time.
> 
> On RHEL 8 tmpfs doesn't seem to support birth time, but on F39 tmpfs does seem to support birth time. Looks like this might be related to the kernel version. It's difficult to enumerate all the combination of file system type and linux kernel version to determine the testd file support birth time or not. So in this PR, I get the result from `statx` linux syscall, to determine the testd file support birth time or not.
> 
> Test fix only, the change has been verified, risk is low.
> 
> Additional test:
> 
> - [x] Alinux3 glibc:2.32
> 1.  /tmp/file supportsCreationTimeRead == false
> 2. ./file supportsCreationTimeRead == true
> - [x] CentOS7 docker container glibc:2.17
> 1.  /tmp/file supportsCreationTimeRead == false
> 2. ./file supportsCreationTimeRead == false

SendaoYan has updated the pull request incrementally with one additional commit since the last revision:

  1. delete #DEBUG block in test/jdk/java/nio/file/attribute/BasicFileAttributeView/libCreationTimeHelper.c; 2. use System.err instead of System.out in test/jdk/java/nio/file/attribute/BasicFileAttributeView/CreationTime.java

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/20687/files
  - new: https://git.openjdk.org/jdk/pull/20687/files/7a7916f4..6d4eb11a

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=20687&range=17
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=20687&range=16-17

  Stats: 6 lines in 2 files changed: 0 ins; 4 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/20687.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/20687/head:pull/20687

PR: https://git.openjdk.org/jdk/pull/20687


More information about the nio-dev mailing list