RFR: 8338884: java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#tmp fails on alinux3 [v17]

SendaoYan syan at openjdk.org
Wed Oct 9 01:17:00 UTC 2024


On Tue, 8 Oct 2024 18:35:53 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

>> SendaoYan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   initail struct stx var to zero
>
> test/jdk/java/nio/file/attribute/BasicFileAttributeView/CreationTime.java line 125:
> 
>> 123:             FileTime current = creationTime(file);
>> 124:             if (!current.equals(creationTime)) {
>> 125:                 System.out.println("current = " + current);
> 
> I think it would be better to use `System.err` on these two lines, as was done at line 81.

Thanks for the review. These two `System.out` has been replaced as `System.err`.

> test/jdk/java/nio/file/attribute/BasicFileAttributeView/libCreationTimeHelper.c line 105:
> 
>> 103:     ret = my_statx_func(AT_FDCWD, file, atflag, mask, &stx);
>> 104: 
>> 105:     #ifdef DEBUG
> 
> This `DEBUG` block could be removed.

`DEBUG` block has been removed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20687#discussion_r1792666449
PR Review Comment: https://git.openjdk.org/jdk/pull/20687#discussion_r1792666818


More information about the nio-dev mailing list