RFR: 8338884: java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#tmp fails on alinux3 [v18]

SendaoYan syan at openjdk.org
Wed Oct 9 06:01:21 UTC 2024


On Wed, 9 Oct 2024 03:03:46 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

>> SendaoYan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   1. delete #DEBUG block in test/jdk/java/nio/file/attribute/BasicFileAttributeView/libCreationTimeHelper.c; 2. use System.err instead of System.out in test/jdk/java/nio/file/attribute/BasicFileAttributeView/CreationTime.java
>
> test/jdk/java/nio/file/attribute/BasicFileAttributeView/CreationTime.java line 80:
> 
>> 78:         Instant now = Instant.now();
>> 79:         if (Math.abs(creationTime.toMillis()-now.toEpochMilli()) > 10000L) {
>> 80:             System.out.println("creationTime.toMillis() == " + creationTime.toMillis());
> 
> Sorry but would you please change line 80 to use `System.err` also? Thanks.

Sorry for miss the replaced. The line 80 has been changed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20687#discussion_r1792888234


More information about the nio-dev mailing list