RFR: 8338884: java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#tmp fails on alinux3 [v19]
SendaoYan
syan at openjdk.org
Thu Oct 10 01:08:27 UTC 2024
On Wed, 9 Oct 2024 06:01:21 GMT, SendaoYan <syan at openjdk.org> wrote:
>> Hi all,
>> On alinux3(alibaba cloud linux version 3) system, the `/tmp` disk partition is mounted as tmpfs filesystem type, this filesystem type doesn't support create time(birth time).
>>
>> Before this PR, this test [check](https://github.com/openjdk/jdk/blob/master/test/jdk/java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#L110) if there is `statx` system call present or not to determise the test environment support birth time or not. I think it's not enough when the tested filesystem type is `tmpfs`. When the tested filesystem type is `tmpfs`, then the tested file doesn't support birth time.
>>
>> On RHEL 8 tmpfs doesn't seem to support birth time, but on F39 tmpfs does seem to support birth time. Looks like this might be related to the kernel version. It's difficult to enumerate all the combination of file system type and linux kernel version to determine the testd file support birth time or not. So in this PR, I get the result from `statx` linux syscall, to determine the testd file support birth time or not.
>>
>> Test fix only, the change has been verified, risk is low.
>>
>> Additional test:
>>
>> - [x] Alinux3 glibc:2.32
>> 1. /tmp/file supportsCreationTimeRead == false
>> 2. ./file supportsCreationTimeRead == true
>> - [x] CentOS7 docker container glibc:2.17
>> 1. /tmp/file supportsCreationTimeRead == false
>> 2. ./file supportsCreationTimeRead == false
>
> SendaoYan has updated the pull request incrementally with one additional commit since the last revision:
>
> Use System.err.println instead of System.out.println in line 80 of test/jdk/java/nio/file/attribute/BasicFileAttributeView/CreationTime.java
Thanks all for the review.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/20687#issuecomment-2403693036
More information about the nio-dev
mailing list