Integrated: 8338884: java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#tmp fails on alinux3

SendaoYan syan at openjdk.org
Thu Oct 10 01:08:28 UTC 2024


On Fri, 23 Aug 2024 03:58:37 GMT, SendaoYan <syan at openjdk.org> wrote:

> Hi all,
> On alinux3(alibaba cloud linux version 3) system, the `/tmp` disk partition is mounted as tmpfs filesystem type, this filesystem type doesn't support create time(birth time).
> 
> Before this PR, this test [check](https://github.com/openjdk/jdk/blob/master/test/jdk/java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#L110) if there is `statx` system call present or not to determise the test environment support birth time or not. I think it's not enough when the tested filesystem type is `tmpfs`. When the tested filesystem type is `tmpfs`, then the tested file doesn't support birth time.
> 
> On RHEL 8 tmpfs doesn't seem to support birth time, but on F39 tmpfs does seem to support birth time. Looks like this might be related to the kernel version. It's difficult to enumerate all the combination of file system type and linux kernel version to determine the testd file support birth time or not. So in this PR, I get the result from `statx` linux syscall, to determine the testd file support birth time or not.
> 
> Test fix only, the change has been verified, risk is low.
> 
> Additional test:
> 
> - [x] Alinux3 glibc:2.32
> 1.  /tmp/file supportsCreationTimeRead == false
> 2. ./file supportsCreationTimeRead == true
> - [x] CentOS7 docker container glibc:2.17
> 1.  /tmp/file supportsCreationTimeRead == false
> 2. ./file supportsCreationTimeRead == false

This pull request has now been integrated.

Changeset: 9d621d39
Author:    SendaoYan <syan at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/9d621d3914b39cfdcda97274a7af5ca0fe062d35
Stats:     207 lines in 4 files changed: 189 ins; 7 del; 11 mod

8338884: java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#tmp fails on alinux3

Reviewed-by: sgehwolf, bpb

-------------

PR: https://git.openjdk.org/jdk/pull/20687


More information about the nio-dev mailing list