RFR: 8233451: (fs) Files.newInputStream() cannot be used with character special files [v3]

Alan Bateman alanb at openjdk.org
Fri Oct 18 10:47:08 UTC 2024


On Thu, 17 Oct 2024 22:55:57 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

>> Add `isOther` and `available` methods to `FileChannelImpl` and the interfaces to native code and use these in `ChannelInputStream` to work around cases where a wrapped `FileChannelImpl` is not really seekable.
>
> Brian Burkhalter has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - 8233451: Do not initialize isOther to null
>  - 8233451: Address reviewer comments; convert test to JUnit 5

The latest update looks okay, maybe we might find a better special file so the readAllXXX methods can be tested.

-------------

Marked as reviewed by alanb (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/21508#pullrequestreview-2377752580


More information about the nio-dev mailing list