RFR: 8233451: (fs) Files.newInputStream() cannot be used with character special files [v2]
Brian Burkhalter
bpb at openjdk.org
Fri Oct 18 15:07:23 UTC 2024
On Fri, 18 Oct 2024 08:06:48 GMT, Alan Bateman <alanb at openjdk.org> wrote:
>> I added test coverage for `skip` but not for `readAllBytes` nor `readNBytes`:
>> - `readAllBytes` throws before but hangs after the change;
>> - `readNBytes` hangs both before and after the change.
>
> I wonder if there is another special file that could be read to EOF to allow the methods be tested. Asking because the overrides have a code path we need to test.
I need to investigate this. I might hold off integrating even thought it's approved until this is determined.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21508#discussion_r1806654280
More information about the nio-dev
mailing list