RFR: 8338383: Implement JEP 491: Synchronize Virtual Threads without Pinning [v5]
Alan Bateman
alanb at openjdk.org
Wed Oct 23 10:04:11 UTC 2024
On Wed, 23 Oct 2024 00:56:34 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>> Patricio Chilano Mateo has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Address David's comments to ObjectMonitor.hpp
>
> src/hotspot/share/runtime/javaThread.cpp line 2002:
>
>> 2000: #ifdef SUPPORT_MONITOR_COUNT
>> 2001:
>> 2002: #ifdef LOOM_MONITOR_SUPPORT
>
> If LOOM_MONITOR_SUPPORT is not true, this would skip this block and assert for LIGHTWEIGHT locking. Do we need this #ifdef ?
LOOM_MONITOR_SUPPORT was only needed when there were ports missing. All 4 are included now so this goes away.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21565#discussion_r1812389702
More information about the nio-dev
mailing list