RFR: 8338426: Test java/nio/channels/Selector/WakeupNow.java failed
Brian Burkhalter
bpb at openjdk.org
Thu Oct 24 15:09:05 UTC 2024
On Thu, 24 Oct 2024 11:06:36 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:
>> test/jdk/java/nio/channels/Selector/WakeupNow.java line 66:
>>
>>> 64: Selector sel = Selector.open();
>>> 65: Pipe p = Pipe.open();
>>> 66: p.source().configureBlocking(false);
>>
>> Hello Brian, is this intentionally being removed?
>
> Looking at this test, this removal appears intentional and it's merely cleaning up unused (and thus irrelevant) `Pipe`. It appears that this was a copy/paste oversight in the original test (even the comment on `test2()` method seems to indicate this `Pipe` was an oversight). So what you did here looks correct.
Hi @jaikiran . Yes it was unused code intentionally removed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21674#discussion_r1815191486
More information about the nio-dev
mailing list