RFR: 8338383: Implement JEP 491: Synchronize Virtual Threads without Pinning [v8]
Patricio Chilano Mateo
pchilanomate at openjdk.org
Thu Oct 24 21:17:15 UTC 2024
On Thu, 24 Oct 2024 08:08:56 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:
>> Patricio Chilano Mateo has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - Fix comment in objectMonitor.hpp and javaThread.hpp
>> - Skip printing tid when not available
>
> src/hotspot/share/runtime/objectMonitor.hpp line 325:
>
>> 323: }
>> 324:
>> 325: bool has_owner_anonymous() const { return owner_raw() == ANONYMOUS_OWNER; }
>
> Small, drive-by comment. The rename to `has_owner_anonymous` sounds worse than the previous `is_owner_anonymous` name. I think the code reads better if you change it to `has_anonymous_owner`.
I renamed both `set/has_owner_anonymous` to `set/has_anonymous_owner`.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21565#discussion_r1815701746
More information about the nio-dev
mailing list