RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager [v3]
Harshitha Onkar
honkar at openjdk.org
Fri Oct 25 17:33:44 UTC 2024
On Fri, 25 Oct 2024 14:57:18 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:
>> Sean Mullan has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 150 commits:
>>
>> - Merge remote-tracking branch 'jdk-sandbox/jep486' into JDK-8338411
>> - Merge
>> - Update @summary to replace "if the right permission is granted" can be replaced with "package java.lang is open to unnamed module".
>> - Remove println about Security Manager.
>> - Remove unused static variable NEW_PROXY_IN_PKG.
>> - Remove static variable `DEFAULT_POLICY` and unused imports.
>> - Remove hasSM() method and code that calls it, and remove comment about
>> running test manually with SM.
>> - clientlibs: import order
>> - warning-string
>> - java/net/httpclient/websocket/security/WSURLPermissionTest.java: integrated review feedback in renamed WSSanityTest.java
>> - ... and 140 more: https://git.openjdk.org/jdk/compare/f7a61fce...cb50dfde
>
> test/jdk/javax/swing/JPopupMenu/6694823/bug6694823.java line 41:
>
>> 39: * @bug 6694823
>> 40: * @summary Checks that popup menu cannot be partially hidden
>> 41: * by the task bar.
>
> I believe this test is irrelevant without the security manager.
>
> The test above, `test/jdk/javax/swing/JPopupMenu/6691503/bug6691503.java` asserts that popup menus in applets don't have their always-on-top flag set to true, therefore such popups will be displayed below the taskbar.
>
> Popup menus in stand-alone apps have their always-on-top flag set to true, therefore they can be displayed on top of the taskbar.
>
> We have a specific test which verifies [`TaskbarPositionTest.java`](https://github.com/openjdk/jdk/blob/master/test/jdk/javax/swing/Popup/TaskbarPositionTest.java) that a popup menu could overlap the taskbar.
This particular test was failing on windows & linux after SM removal. There is a functional issue and for that reason I think it is better to retain this test. Details documented here - [JDK-8342012](https://bugs.openjdk.org/browse/JDK-8342012)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21498#discussion_r1817093001
More information about the nio-dev
mailing list