RFR: 8338383: Implement JEP 491: Synchronize Virtual Threads without Pinning [v9]
David Holmes
dholmes at openjdk.org
Mon Oct 28 00:34:14 UTC 2024
On Fri, 25 Oct 2024 18:42:29 GMT, Patricio Chilano Mateo <pchilanomate at openjdk.org> wrote:
>> src/hotspot/share/runtime/objectMonitor.hpp line 349:
>>
>>> 347: ObjectWaiter* first_waiter() { return _WaitSet; }
>>> 348: ObjectWaiter* next_waiter(ObjectWaiter* o) { return o->_next; }
>>> 349: JavaThread* thread_of_waiter(ObjectWaiter* o) { return o->_thread; }
>>
>> This no longer looks correct if the waiter is a vthread. ??
>
> It is, we still increment _waiters for the vthread case.
Sorry the target of my comment was not clear. `thread_of_waiter` looks suspicious - will JVMTI find the vthread from the JavaThread?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21565#discussion_r1818236368
More information about the nio-dev
mailing list