RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager [v3]
Sean Mullan
mullan at openjdk.org
Mon Oct 28 15:09:54 UTC 2024
On Fri, 25 Oct 2024 20:59:07 GMT, Roger Riggs <rriggs at openjdk.org> wrote:
>> Sean Mullan has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 150 commits:
>>
>> - Merge remote-tracking branch 'jdk-sandbox/jep486' into JDK-8338411
>> - Merge
>> - Update @summary to replace "if the right permission is granted" can be replaced with "package java.lang is open to unnamed module".
>> - Remove println about Security Manager.
>> - Remove unused static variable NEW_PROXY_IN_PKG.
>> - Remove static variable `DEFAULT_POLICY` and unused imports.
>> - Remove hasSM() method and code that calls it, and remove comment about
>> running test manually with SM.
>> - clientlibs: import order
>> - warning-string
>> - java/net/httpclient/websocket/security/WSURLPermissionTest.java: integrated review feedback in renamed WSSanityTest.java
>> - ... and 140 more: https://git.openjdk.org/jdk/compare/f7a61fce...cb50dfde
>
> test/micro/org/openjdk/bench/java/security/ProtectionDomainBench.java line 125:
>
>> 123: }
>> 124:
>> 125: @Benchmark
>
> Is this benchmark still useful if it is not comparing the SM vs the Non-SM case?
`ProtectionDomain` has not been deprecated and classes are still populated with PDs w/o an SM, so it may still have some value for measuring performance and detecting regressions/improvements.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21498#discussion_r1819242889
More information about the nio-dev
mailing list