RFR: 8338383: Implement JEP 491: Synchronize Virtual Threads without Pinning [v12]
Coleen Phillimore
coleenp at openjdk.org
Mon Oct 28 16:41:32 UTC 2024
On Sat, 26 Oct 2024 01:51:12 GMT, Dean Long <dlong at openjdk.org> wrote:
>> Patricio Chilano Mateo has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - Restore use of atPointA in test StopThreadTest.java
>> - remove interruptible check from conditional in Object::wait
>
> src/hotspot/cpu/aarch64/stackChunkFrameStream_aarch64.inline.hpp line 119:
>
>> 117: return mask.num_oops()
>> 118: + 1 // for the mirror oop
>> 119: + (f.interpreter_frame_method()->is_native() ? 1 : 0) // temp oop slot
>
> Where is this temp oop slot set and used?
It's the offset of the mirror passed to static native calls. It pre-existed saving the mirror in all frames to keep the Method alive, and is duplicated. I think this could be cleaned up someday, which would remove this special case.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21565#discussion_r1819394224
More information about the nio-dev
mailing list