RFR: 8339783: Implementation of JEP 479: Remove the Windows 32-bit x86 Port
Aleksey Shipilev
shade at openjdk.org
Tue Oct 29 09:51:12 UTC 2024
On Mon, 28 Oct 2024 23:15:36 GMT, Erik Joelsson <erikj at openjdk.org> wrote:
>> make/modules/jdk.accessibility/Launcher.gmk line 56:
>>
>>> 54: $(eval $(call SetupJdkExecutable, BUILD_JACCESSINSPECTOR, \
>>> 55: NAME := jaccessinspector, \
>>> 56: EXTRA_SRC := \
>>
>> I might be missing something here. Original block has `SRC` parameter, do we not need it anymore?
>>
>> Similar thing in `BUILD_JACCESSWALKER` and `BUILD_LIBJAVAACCESSBRIDGE` below.
>
> I think it was needed when the name didn't match the src dir, due to the `$1` suffix, but now we don't have that complication anymore.
OK, good, as long as it was intentional.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21744#discussion_r1820460415
More information about the nio-dev
mailing list