RFR: 8339783: Implementation of JEP 479: Remove the Windows 32-bit x86 Port [v7]

Magnus Ihse Bursie ihse at openjdk.org
Tue Oct 29 15:19:03 UTC 2024


On Tue, 29 Oct 2024 15:08:47 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> src/hotspot/os/windows/os_windows.cpp line 2615:
>> 
>>> 2613:   Thread* t = Thread::current_or_null_safe();
>>> 2614: 
>>> 2615: #if defined(_M_AMD64)
>> 
>> The check for LP64 on line 2622 below seems redundant now
>
> Indeed, nice catch! I also found another place in this file that were guarded by `_LP64` that I removed. I also did a grep on `LP64` in `hotspot/os/windows`, but there were no more instances.

... however, there is also `hotspot/os_cpu/windows_x86` to check, and there I also found another instance.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21744#discussion_r1821007811


More information about the nio-dev mailing list