RFR: 8339783: Implement JEP 479: Remove the Windows 32-bit x86 Port [v13]

David Holmes dholmes at openjdk.org
Wed Oct 30 02:21:11 UTC 2024


On Tue, 29 Oct 2024 15:30:44 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> src/hotspot/share/utilities/globalDefinitions_visCPP.hpp line 55:
>> 
>>> 53: #error unsupported platform
>>> 54: #endif
>>> 55: 
>> 
>> Does Windows Aarch64 define _LP64?
>
> Yes. As Julian says, it's something we set up in our builds:
> 
>   if test "x$FLAGS_CPU_BITS" = x64; then
>     $1_DEFINES_CPU_JDK="${$1_DEFINES_CPU_JDK} -D_LP64=1"
>     $1_DEFINES_CPU_JVM="${$1_DEFINES_CPU_JVM} -D_LP64=1"
>   fi

Ugghh! I was thrown by the `x` in test expressions and thought `x64` meant, well, x64 :)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21744#discussion_r1821763177


More information about the nio-dev mailing list