RFR: 8339783: Implement JEP 479: Remove the Windows 32-bit x86 Port [v13]

Kim Barrett kbarrett at openjdk.org
Wed Oct 30 03:44:24 UTC 2024


On Tue, 29 Oct 2024 09:51:16 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> src/hotspot/share/prims/jvm.cpp line 381:
>> 
>>> 379:   {
>>> 380: #undef CSIZE
>>> 381: #if defined(_LP64)
>> 
>> Windows is actually LLP64 programming model not LP64. Does Windows x64 define _LP64 or is that something we do in our build?
>
> It's something we do in our build. For us, _LP64 really means 64 bit

It seems like the `_WIN64` check here was never useful.  It's also been there since before the
mercurial age.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21744#discussion_r1821799991


More information about the nio-dev mailing list