RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager [v5]

Sean Mullan mullan at openjdk.org
Wed Oct 30 20:16:46 UTC 2024


On Tue, 29 Oct 2024 18:35:05 GMT, Brent Christian <bchristi at openjdk.org> wrote:

>> Sean Mullan has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 186 commits:
>> 
>>  - Merge remote-tracking branch 'jdk-sandbox/jep486' into JDK-8338411
>>  - Update copyrights. Remove @compile line form Marshal.java test.
>>  - Update copyright headers
>>  - Adjust Executors.privilegedThreadFactory to make clear that thread uses current CCL
>>  - Merge branch 'master' into jep486
>>  - ResourceBundle/modules/security/* no longer needed. TestPermission tested against getModule(String, Module) w/ SM.
>>  - remove privileged calls in logging/File* tests
>>  - delete PermissionTest.java as it simply constructs provider impls
>>  - remove non enforced/redundant comment in TestLogConfigurationDeadLockWithConf.java
>>  - clientlibs: Updated javax/swing/UIDefaults/6622002/bug6622002.java
>>    Removed createPrivateValue(), no longer used.
>>  - ... and 176 more: https://git.openjdk.org/jdk/compare/df3473e2...2f90c839
>
> src/java.base/share/classes/java/util/concurrent/Executors.java line 392:
> 
>> 390:     /**
>> 391:      * Returns a thread factory used to create new threads that
>> 392:      * have current context class loader as the context class loader.
> 
> One nit for your consideration: "...to create new threads that have **_the_** current context class loader..."

Fixed in https://github.com/openjdk/jdk/pull/21498/commits/06c4c3c1ab1fe121b625bd30a0c424be06d5022a

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21498#discussion_r1823307856


More information about the nio-dev mailing list