RFR: 8338383: Implement JEP 491: Synchronize Virtual Threads without Pinning [v22]
Patricio Chilano Mateo
pchilanomate at openjdk.org
Thu Oct 31 16:38:12 UTC 2024
On Thu, 31 Oct 2024 16:34:41 GMT, Patricio Chilano Mateo <pchilanomate at openjdk.org> wrote:
>> General convention is that racily accessed variables should be accessed via Atomic::load/store to make it clear(er) they are racy accesses. But I agree it seems odd when direct accesses to `_succ` in the main cpp file are not atomic.
>
>> Why are _succ accesses atomic here when previously they were not?
>>
> They should had always been atomic.
> But I agree it seems odd when direct accesses to _succ in the main cpp file are not atomic.
>
There was only one remaining direct access in debugging function `print_debug_style_on` which I fixed now.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21565#discussion_r1824794795
More information about the nio-dev
mailing list