RFR: 8338884: java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#tmp fails on alinux3 [v5]
SendaoYan
syan at openjdk.org
Tue Sep 3 07:38:21 UTC 2024
On Tue, 3 Sep 2024 07:27:15 GMT, Alan Bateman <alanb at openjdk.org> wrote:
>> SendaoYan has updated the pull request incrementally with one additional commit since the last revision:
>>
>> use stat -c linux command line to determise support create time or not
>
> test/jdk/java/nio/file/attribute/BasicFileAttributeView/CreationTime.java line 164:
>
>> 162: String l = b.readLine();
>> 163: if (l != null && l.equals("-")) { return false; }
>> 164: } catch(Exception e) {
>
> There are several bugs/issues with this method, did you mean to bring it back? If we are launching subprocesses in this test then it can use ProcessTools infrastructure.
It's difficult to enumerate all the combination of file system type and linux kernel version to determine the testd file support birth time or not, So I want to bring it back.
Thanks for the advice, I will use `ProcessTools infrastructure` later.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20687#discussion_r1741575123
More information about the nio-dev
mailing list