RFR: 8338884: java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#tmp fails on alinux3 [v10]

SendaoYan syan at openjdk.org
Fri Sep 6 09:55:53 UTC 2024


On Fri, 6 Sep 2024 09:03:13 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> SendaoYan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix typo support to supported
>
> test/jdk/java/nio/file/attribute/BasicFileAttributeView/libCreationTimeHelper.c line 30:
> 
>> 28:   #define true 1
>> 29:   #define false 0
>> 30: #endif
> 
> Do we really need this? Since https://openjdk.org/jeps/347 test libraries should be compiled with `--std=c11`.

I am not quite sure, I copied these codes from `src/java.base/unix/native/libjsig/jsig.c`. I will check it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20687#discussion_r1746859383


More information about the nio-dev mailing list